To: vim_dev@googlegroups.com Subject: Patch 8.2.2828 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.2828 Problem: Coverity complains about not checking the rename() return value. Solution: Add "(void)", can't do anything in case of a failure. Files: src/fileio.c *** ../vim-8.2.2827/src/fileio.c 2021-01-04 10:47:21.694153978 +0100 --- src/fileio.c 2021-05-03 19:47:18.848295850 +0200 *************** *** 3733,3739 **** return 0; // Strange, the second step failed. Try moving the // file back and return failure. ! mch_rename(tempname, (char *)from); return -1; } // If it fails for one temp name it will most likely fail --- 3733,3739 ---- return 0; // Strange, the second step failed. Try moving the // file back and return failure. ! (void)mch_rename(tempname, (char *)from); return -1; } // If it fails for one temp name it will most likely fail *** ../vim-8.2.2827/src/version.c 2021-05-03 19:08:33.482050717 +0200 --- src/version.c 2021-05-03 19:49:18.223973785 +0200 *************** *** 752,753 **** --- 752,755 ---- { /* Add new patch number below this line */ + /**/ + 2828, /**/ -- hundred-and-one symptoms of being an internet addict: 223. You set up a web-cam as your home's security system. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///