To: vim_dev@googlegroups.com Subject: Patch 8.2.3588 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.3588 Problem: Break statement is never reached. Solution: Rely on return value of set_chars_option() not changing. (closes #9103) Files: src/optionstr.c *** ../vim-8.2.3587/src/optionstr.c 2021-10-20 11:01:10.756166697 +0100 --- src/optionstr.c 2021-11-12 19:50:41.705669928 +0000 *************** *** 1331,1341 **** if (!(opt_flags & OPT_GLOBAL)) clear_string_option(&curwin->w_p_lcs); FOR_ALL_TAB_WINDOWS(tp, wp) ! { ! errmsg = set_chars_option(wp, &wp->w_p_lcs); ! if (errmsg) ! break; ! } redraw_all_later(NOT_VALID); } } --- 1331,1340 ---- if (!(opt_flags & OPT_GLOBAL)) clear_string_option(&curwin->w_p_lcs); FOR_ALL_TAB_WINDOWS(tp, wp) ! // If no error was returned above, we don't expect an error ! // here, so ignore the return value. ! (void)set_chars_option(wp, &wp->w_p_lcs); ! redraw_all_later(NOT_VALID); } } *** ../vim-8.2.3587/src/version.c 2021-11-12 16:09:50.841027774 +0000 --- src/version.c 2021-11-12 19:52:20.308130014 +0000 *************** *** 759,760 **** --- 759,762 ---- { /* Add new patch number below this line */ + /**/ + 3588, /**/ -- A real patriot is the fellow who gets a parking ticket and rejoices that the system works. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///