To: vim_dev@googlegroups.com Subject: Patch 8.2.5127 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.5127 Problem: Using assert_true() does not show value on failure. Solution: Use assert_inrange(). (closes #10593) Files: src/testdir/test_channel.vim, src/testdir/test_hlsearch.vim *** ../vim-8.2.5126/src/testdir/test_channel.vim 2022-04-19 10:25:04.249373674 +0100 --- src/testdir/test_channel.vim 2022-06-19 11:35:26.923942324 +0100 *************** *** 528,534 **** call ch_close(handle) else let elapsed = reltime(start) ! call assert_true(reltimefloat(elapsed) < 1.0) endif " We intend to use a socket that doesn't exist and wait for half a second --- 528,534 ---- call ch_close(handle) else let elapsed = reltime(start) ! call assert_inrange(0.0, 1.0, reltimefloat(elapsed)) endif " We intend to use a socket that doesn't exist and wait for half a second *************** *** 1634,1641 **** let g:exit_cb_val.process = job_info(job).process call WaitFor('type(g:exit_cb_val.end) != v:t_number || g:exit_cb_val.end != 0') let elapsed = reltimefloat(g:exit_cb_val.end) ! call assert_true(elapsed > 0.5) ! call assert_true(elapsed < 1.0) " case: unreferenced job, using timer if !has('timers') --- 1634,1640 ---- let g:exit_cb_val.process = job_info(job).process call WaitFor('type(g:exit_cb_val.end) != v:t_number || g:exit_cb_val.end != 0') let elapsed = reltimefloat(g:exit_cb_val.end) ! call assert_inrange(0.5, 1.0, elapsed) " case: unreferenced job, using timer if !has('timers') *** ../vim-8.2.5126/src/testdir/test_hlsearch.vim 2022-06-05 16:55:50.702774344 +0100 --- src/testdir/test_hlsearch.vim 2022-06-19 11:32:40.691896981 +0100 *************** *** 54,61 **** let @/ = '\%#=1a*.*X\@<=b*' redraw let elapsed = reltimefloat(reltime(start)) ! call assert_true(elapsed > min_timeout) ! call assert_true(elapsed < 1.0) set nohlsearch redrawtime& bwipe! endfunc --- 54,60 ---- let @/ = '\%#=1a*.*X\@<=b*' redraw let elapsed = reltimefloat(reltime(start)) ! call assert_inrange(min_timeout, 1.0, elapsed) set nohlsearch redrawtime& bwipe! endfunc *** ../vim-8.2.5126/src/version.c 2022-06-18 19:48:10.813508250 +0100 --- src/version.c 2022-06-19 11:34:06.627920311 +0100 *************** *** 736,737 **** --- 736,739 ---- { /* Add new patch number below this line */ + /**/ + 5127, /**/ -- Friends? I have lots of friends! In fact, I have all episodes ever made. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///